-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(dev): upgrade APISIX to 3.9.0 (#750) #751
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -29,7 +29,7 @@ image: | |||
pullPolicy: IfNotPresent | |||
# -- Apache APISIX image tag | |||
# Overrides the image tag whose default is the chart appVersion. | |||
tag: 3.8.0-debian | |||
tag: 3.9.0-debian |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should move enable_http2
https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix/values.yaml#L274 under apisix
in this file, just like https://github.com/apache/apisix/pull/11032/files#diff-8d872babc717e9d733641b56bfc530ef98751fbe4e68f08d79b2b83109c22fffR36
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that there is a better implementation. Please close this PR and look forward to the next release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any progress or plain?
@@ -66,6 +66,7 @@ data: | |||
enable_dev_mode: false # Sets nginx worker_processes to 1 if set to true | |||
enable_reuseport: true # Enable nginx SO_REUSEPORT switch if set to true. | |||
enable_ipv6: {{ .Values.apisix.enableIPv6 }} # Enable nginx IPv6 resolver | |||
enable_http2: {{ .Values.apisix.ssl.http2.enabled }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enable_http2: {{ .Values.apisix.ssl.http2.enabled }} | |
enable_http2: {{ .Values.apisix.enableHTTP2}} |
@moonming @AlinsRan @Revolyssup Sorry, any progress on that? Are there any blockers in releasing a new version of the chart with support for the 3.9.0 version? |
refs: #738 Continue at this PR: #754 |
https://github.com/apache/apisix/blob/release/3.9.0/CHANGELOG.md#390