feat: Autogenerate random API Key with helm install if not passed #740
Conversation
| @@ -326,6 +326,8 @@ data: | |||
| - name: "admin" | |||
| {{- if .Values.apisix.admin.credentials.secretName }} | |||
| key: ${{"{{"}}APISIX_ADMIN_KEY{{"}}"}} | |||
| {{- else if eq .Values.apisix.admin.credentials.admin "" }} | |||
| key: {{ randAlphaNum 32 }} | |||
There was a problem hiding this comment.
How do users know the key? You need to add a prompt output.
Perhaps managing admin-key through a secret would be more appropriate.
What do you think？
There was a problem hiding this comment.
Since this is in the confimap. Users can look at the configmap using kubectl to look at the key. Is there an issue there?
There was a problem hiding this comment.
I think we can write how to get the key in the docs.
There was a problem hiding this comment.
I have added that in the README against this particular key. https://github.com/apache/apisix-helm-chart/pull/740/files#diff-3169e4e147b847e17edc927d65d4aa9cb5db1a436d62acf059c166e898f9f3fdR46
There was a problem hiding this comment.
You can add a prompt here.
https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix/templates/NOTES.txt
There was a problem hiding this comment.
Is it regenerated when upgrading the version?
This PR is part of the proposal which removes hardcoding of sensitive API keys by autogenerating them at either application level(APISIX) or deployment level(like helm chart.)