Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: inHTTP.Header #156

Merged
merged 4 commits into from
Jan 22, 2024
Merged

refactor: inHTTP.Header #156

merged 4 commits into from
Jan 22, 2024

Conversation

reatang
Copy link
Contributor

@reatang reatang commented Jan 17, 2024

Header should manage its own changes and builds

Header should manage its own changes and builds
@monkeyDluffy6017
Copy link

So what you have done is encapsulating releated methods in the header object?

@monkeyDluffy6017
Copy link

please make the ci pass

@reatang
Copy link
Contributor Author

reatang commented Jan 18, 2024

So what you have done is encapsulating releated methods in the header object?

Yes, make the Header function cohesive.


In fact, from a programming perspective, it should not be designed in this way, which couples the presentation layer and the application layer. An encoding layer for fbs and golang objects should be provided.
Now what I do is explicitly layer it in a class.

其实从程序设计角度来说,不应该如此设计,这让表现层和应用层耦合了。应该提供一层 fbs 和 golang 对象的转换层。现在我做的就是在一个类型中显式的分层。

@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a265bcd) 79.62% compared to head (5b5d631) 79.78%.

❗ Current head 5b5d631 differs from pull request most recent head 8a00498. Consider uploading reports for the commit 8a00498 to get more accurate results

Files Patch % Lines
internal/http/header.go 97.82% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
+ Coverage   79.62%   79.78%   +0.16%     
==========================================
  Files          17       17              
  Lines        1060     1039      -21     
==========================================
- Hits          844      829      -15     
+ Misses        164      158       -6     
  Partials       52       52              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@monkeyDluffy6017
Copy link

please make the ci pass

@monkeyDluffy6017 monkeyDluffy6017 merged commit 3bf72a2 into apache:master Jan 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants