-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: inHTTP.Header #156
Conversation
Header should manage its own changes and builds
So what you have done is encapsulating releated methods in the |
please make the ci pass |
Yes, make the Header function cohesive. In fact, from a programming perspective, it should not be designed in this way, which couples the presentation layer and the application layer. An encoding layer for 其实从程序设计角度来说,不应该如此设计,这让表现层和应用层耦合了。应该提供一层 fbs 和 golang 对象的转换层。现在我做的就是在一个类型中显式的分层。 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #156 +/- ##
==========================================
+ Coverage 79.62% 79.78% +0.16%
==========================================
Files 17 17
Lines 1060 1039 -21
==========================================
- Hits 844 829 -15
+ Misses 164 158 -6
Partials 52 52 ☔ View full report in Codecov by Sentry. |
please make the ci pass |
Header should manage its own changes and builds