Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: example containers using old images #542

Closed
wants to merge 5 commits into from

Conversation

lucabotti
Copy link

Fixed issue for #417

@zll600
Copy link

zll600 commented Jan 29, 2024

@monkeyDluffy6017 Could you help review this?

@monkeyDluffy6017
Copy link
Contributor

It looks like there is something wrong with the ci

@lucabotti
Copy link
Author

The issue seems related to unavailability of Docker hub - RH build passed, Debian was not.

@monkeyDluffy6017
Copy link
Contributor

monkeyDluffy6017 commented Feb 4, 2024

Could you fix this ci error?
image
you can follow this:
apache/apisix@f91861f

@lucabotti
Copy link
Author

Sorry, @monkeyDluffy6017 I guess is outside of my reach.

image

Certificate has expired on 22nd of January. Builds outside of China works correctly.

@monkeyDluffy6017
Copy link
Contributor

@lucabotti you can do like this:
image

@monkeyDluffy6017 monkeyDluffy6017 changed the title Updated Tags for docker images, fixes issue #417 fix: update tags for docker images Feb 19, 2024
@monkeyDluffy6017 monkeyDluffy6017 changed the title fix: update tags for docker images fix: example containers using old images Feb 19, 2024
@monkeyDluffy6017
Copy link
Contributor

monkeyDluffy6017 commented Feb 19, 2024

I don't think we need the latest version, the lts version is better.
And we have not tested the compatibility of these components, It's best to leave it as it is.

Copy link

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time ordiscuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 19, 2024
Copy link

This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants