fix: sed not suitable for docker if config.yaml is volume mounted #529 #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
your fix should work fine, could you also add test cases? |
monkeyDluffy6017
approved these changes
Jan 5, 2024
|
Should this be applied to 3.7.0 as well and have new images pushed? Or just wait for 3.8.0? |
|
@kayx23 Yeah, it will affect version 3.6.0 and 3.7.0, maybe we should update both 3.6.0 and 3.7.0 images |
|
Following up on this PR. Do we have to wait for the test cases or are we comfortable with this fix to move ahead? |
|
It will affect the release of apisix, so we could approve this release first, i have created an issue here for the test case: #536 |
|
Whose review are we waiting on now? |
AlinsRan
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix: config.yaml couldn't be volume mounted when using standalone Deployment modes (#529)