fix: update ETCD_ADVERTISE_CLIENT_URLS from 0.0.0.0 to FQDN #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI failure seems to be unrelated to the change? The same ssl error was observed throughout the scheduled actions last week.
|
|
Yeah the CI error is not related at all. Tested in my repo with a trivial change (adding a whitespace) and it's still failing for SSL. cc: @shreemaan-abhishek |
monkeyDluffy6017
approved these changes
Jan 4, 2024
shreemaan-abhishek
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ETCD_ADVERTISE_CLIENT_URLS should not be 0.0.0.0.
Related issue: #454
The same issue was also reported by @bzp2010 to me for api7 docs.