AMBARI-26131:Fix ambari-metrics-collector service check failed and resolve jar conflict problem #131

xijunmu · 2024-09-09T11:44:16Z

What changes were proposed in this pull request?

After ambari-metrics-collector installed, i find the service check is failed. So i check the service port 6188 on host. The port is listened but access the url is failed return 500 (http://x.x.x.x:6188/ws/v1/timeline/metrics/livenodes)
Finally i find warn log about ambari-metrics-collector.It seems to be caused by jar conflict

At the same time, I upgraded some jar versions：
to solve the CVE problem：
    1.upgrade commons-io to 2.8.0
    2.upgrade guava to 32.1.1-jre
adapt to bigtop3 and modify tar.gz download url：
    1.upgrade kafka to 2.8.2
    2.upgrade zookeeper to 3.7.2
    3.upgrade hbase to 2.4.17
    4.upgrade hadoop to 3.3.6
    5.upgrade phoenix to 2.4-5.1.3
add missing jar：
    1.sqlline

How was this patch tested?

1.build ambari-metrics
mvn clean package -Dbuild-rpm -Drat.skip=true -DskipTests -Dmaven.test.skip=true

2.install ambari-metrics

2.upgrade commons-io to 2.8.0 3.upgrade guava to 32.1.1-jre 4.upgrade kafka to 2.8.2 5.upgrade zookeeper to 3.7.2 6.upgrade hbase to 2.4.17 7.upgrade hadoop to 3.3.6 8.add missing jar sqlline

2.modify download url

xijunmu · 2024-09-09T11:52:55Z

@brahmareddybattula @kevinw66 @virajjasani Hi guys，could somebody help review this pr?

virajjasani · 2024-09-09T16:37:36Z

Nice one, this looks good. For those exclusions that you commented, we can remove them.

ambari-metrics-assembly/pom.xml

virajjasani · 2024-09-10T06:19:53Z

+1, @JiaLiangC any review from your side?

JiaLiangC · 2024-09-12T00:56:22Z

@virajjasani Sorry for the late reply. It's strange that I didn't receive any email notifications for Ambari Metrics PRs or mentions. This PR corrects the download URLs for Hadoop binaries, etc. Excluding the Hadoop and HBase dependencies from Phoenix and explicitly declaring them is indeed more elegant. LGTM +1

virajjasani · 2024-09-12T01:08:07Z

I am not sure what release version we need to use while closing Jira related to metrics repo.

JiaLiangC · 2024-09-12T01:44:06Z

I am not sure what release version we need to use while closing Jira related to metrics repo.

Indeed, it's difficult to determine the version in which the issue will be resolved. Ideally, Ambari Metrics should maintain version consistency with Ambari for better management, but Metrics has already released version 3.0... What do you think about 3.1?

virajjasani · 2024-09-12T01:46:42Z

Yes I was thinking about the same. It's time to release 3.1. These are some of the good fixes that we should release.

vishalsuvagia · 2024-09-22T17:46:19Z

ambari-metrics-common/pom.xml

@@ -103,7 +103,6 @@
    <dependency>
      <groupId>com.google.guava</groupId>
      <artifactId>guava</artifactId>
-      <version>28.0-jre</version>


it would be good to provide a version here ?

I think the parent pom's guava version should be used, so I deleted the separate version in here

vishalsuvagia · 2024-09-22T17:46:32Z

ambari-metrics-flume-sink/pom.xml

@@ -141,7 +141,6 @@ limitations under the License.
    <dependency>
      <groupId>com.google.guava</groupId>
      <artifactId>guava</artifactId>
-      <version>18.0</version>


can you add a version here as well ?

Same as the previous comment

vishalsuvagia · 2024-09-22T17:48:25Z

pom.xml

+    <hbase.folder>hbase-2.4.17</hbase.folder>
+    <hadoop.tar>https://archive.apache.org/dist/hadoop/common/hadoop-3.3.6/hadoop-3.3.6.tar.gz</hadoop.tar>
+    <hadoop.folder>hadoop-3.3.6</hadoop.folder>
+    <hadoop.version>3.3.6</hadoop.version>


should we have the hadoop version in sync with ambari where it is 3.3.4 currently ?
or bump up the version in ambari as well ?

Nice one, I think we should bump in ambari also.

sandeep318kumar · 2024-09-25T21:07:39Z

@xijunmu CI has failed for this. Can you check and update?

xijunmu · 2024-09-26T09:24:36Z

@sandeep318kumar I checked the code and found that the CI failure was not caused by this PR It is caused by some Python libraries

......

[INFO] --- exec:1.2.1:exec (python-test) @ ambari-metrics-host-monitoring ---
Running tests
testApplicationMetricMap (TestApplicationMetricMap.TestApplicationMetricMap) ... ok
testEmptyMapReturnNone (TestApplicationMetricMap.TestApplicationMetricMap) ... ok
testFlattenAndClear (TestApplicationMetricMap.TestApplicationMetricMap) ... ok
test_flatten_and_align_values_by_minute_mark (TestApplicationMetricMap.TestApplicationMetricMap) ... ok
TestEmitter (unittest.loader._FailedTest) ... ERROR
TestMetricCollector (unittest.loader._FailedTest) ... ERROR
testCombinedDiskUsage (TestHostInfo.TestHostInfo) ... ok
testCpuTimes (TestHostInfo.TestHostInfo) ... ok
testDiskIOCounters (TestHostInfo.TestHostInfo) ... ok
testMemInfo (TestHostInfo.TestHostInfo) ... ERROR
testProcessInfo (TestHostInfo.TestHostInfo) ... ok
test_get_disk_io_counters_per_disk (TestHostInfo.TestHostInfo) ... ok
test_get_network_info_skip_by_pattern (TestHostInfo.TestHostInfo) ... ok
test_get_network_info_skip_by_pattern_and_virtual (TestHostInfo.TestHostInfo) ... ok
test_get_network_info_virtual_devices (TestHostInfo.TestHostInfo) ... ok
test_get_virtual_network_interfaces (TestHostInfo.TestHostInfo) ... ok

======================================================================
ERROR: TestEmitter (unittest.loader._FailedTest)

ImportError: Failed to import test module: TestEmitter
Traceback (most recent call last):
File "/opt/ambari/ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/spnego_kerberos_auth.py", line 27, in
import kerberos
ModuleNotFoundError: No module named 'kerberos'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "/usr/lib64/python3.6/unittest/loader.py", line 153, in loadTestsFromName
module = import(module_name)
File "/opt/ambari/ambari-metrics/ambari-metrics-host-monitoring/src/test/python/core/TestEmitter.py", line 29, in
from spnego_kerberos_auth import SPNEGOKerberosAuth
File "/opt/ambari/ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/spnego_kerberos_auth.py", line 29, in
from resource_monitoring.core import krberr as kerberos
ModuleNotFoundError: No module named 'resource_monitoring'

======================================================================
ERROR: TestMetricCollector (unittest.loader._FailedTest)

ImportError: Failed to import test module: TestMetricCollector
Traceback (most recent call last):
File "/usr/lib64/python3.6/unittest/loader.py", line 153, in loadTestsFromName
module = import(module_name)
File "/opt/ambari/ambari-metrics/ambari-metrics-host-monitoring/src/test/python/core/TestMetricCollector.py", line 25, in
from core.metric_collector import MetricsCollector
File "/opt/ambari/ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/metric_collector.py", line 23, in
from resource_monitoring.core.event_definition import HostMetricCollectEvent, ProcessMetricCollectEvent
ModuleNotFoundError: No module named 'resource_monitoring'

======================================================================
ERROR: testMemInfo (TestHostInfo.TestHostInfo)

Traceback (most recent call last):
File "/opt/ambari/ambari-metrics/ambari-metrics-host-monitoring/src/test/python/mock/mock.py", line 1199, in patched
return func(*args, **keywargs)
File "/opt/ambari/ambari-metrics/ambari-metrics-host-monitoring/src/test/python/core/TestHostInfo.py", line 82, in testMemInfo
mem = hostinfo.get_mem_info()
File "/opt/ambari/ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/host_info.py", line 125, in get_mem_info
'mem_total': bytes2kilobytes(mem_total) if mem_total else 0,
File "/opt/ambari/ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/host_info.py", line 122, in
bytes2kilobytes = lambda x: x / 1024
TypeError: unsupported operand type(s) for /: 'MagicMock' and 'int'

Ran 16 tests in 0.063s

FAILED (errors=3)

Failed tests:
ERROR: TestEmitter (unittest.loader._FailedTest)

ImportError: Failed to import test module: TestEmitter
Traceback (most recent call last):
File "/opt/ambari/ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/spnego_kerberos_auth.py", line 27, in
import kerberos
ModuleNotFoundError: No module named 'kerberos'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "/usr/lib64/python3.6/unittest/loader.py", line 153, in loadTestsFromName
module = import(module_name)
File "/opt/ambari/ambari-metrics/ambari-metrics-host-monitoring/src/test/python/core/TestEmitter.py", line 29, in
from spnego_kerberos_auth import SPNEGOKerberosAuth
File "/opt/ambari/ambari-metrics/ambari-metrics-host-monitoring/sdiskio(read_count=0, write_count=1, read_bytes=2, write_bytes=3, read_time=4, write_time=5)
src/main/python/core/spnego_kerberos_auth.py", line 29, in
from resource_monitoring.core import krberr as kerberos
ModuleNotFoundError: No module named 'resource_monitoring'

ERROR: TestMetricCollector (unittest.loader._FailedTest)

ImportError: Failed to import test module: TestMetricCollector
Traceback (most recent call last):
File "/usr/lib64/python3.6/unittest/loader.py", line 153, in loadTestsFromName
module = import(module_name)
File "/opt/ambari/ambari-metrics/ambari-metrics-host-monitoring/src/test/python/core/TestMetricCollector.py", line 25, in
from core.metric_collector import MetricsCollector
File "/opt/ambari/ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/metric_collector.py", line 23, in
from resource_monitoring.core.event_definition import HostMetricCollectEvent, ProcessMetricCollectEvent
ModuleNotFoundError: No module named 'resource_monitoring'

ERROR: testMemInfo (TestHostInfo.TestHostInfo)

Traceback (most recent call last):
File "/opt/ambari/ambari-metrics/ambari-metrics-host-monitoring/src/test/python/mock/mock.py", line 1199, in patched
return func(*args, **keywargs)
File "/opt/ambari/ambari-metrics/ambari-metrics-host-monitoring/src/test/python/core/TestHostInfo.py", line 82, in testMemInfo
mem = hostinfo.get_mem_info()
File "/opt/ambari/ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/host_info.py", line 125, in get_mem_info
'mem_total': bytes2kilobytes(mem_total) if mem_total else 0,
File "/opt/ambari/ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/host_info.py", line 122, in
bytes2kilobytes = lambda x: x / 1024
TypeError: unsupported operand type(s) for /: 'MagicMock' and 'int'

Total run:16
Total errors:3
Total failures:0
ERROR
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for ambari-metrics 3.1.0-SNAPSHOT:
[INFO]
[INFO] ambari-metrics ..................................... SUCCESS [ 5.623 s]
[INFO] Ambari Metrics Common .............................. SUCCESS [01:09 min]
[INFO] Ambari Metrics Hadoop Sink ......................... SUCCESS [ 22.543 s]
[INFO] Ambari Metrics Flume Sink .......................... SUCCESS [ 14.651 s]
[INFO] Ambari Metrics Kafka Sink .......................... SUCCESS [ 15.066 s]
[INFO] Ambari Metrics Storm Sink .......................... SUCCESS [ 11.955 s]
[INFO] Ambari Metrics Collector ........................... SUCCESS [06:26 min]
[INFO] Ambari Metrics Monitor ............................. FAILURE [ 4.433 s]
[INFO] Ambari Metrics Grafana ............................. SKIPPED
[INFO] Ambari Metrics Host Aggregator ..................... SKIPPED
[INFO] Ambari Metrics Assembly ............................ SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------

sandeep318kumar · 2024-09-26T12:10:30Z

@xijunmu I have resolved these build failures in this PR: #133

xijunmu · 2024-09-27T02:05:34Z

@sandeep318kumar nice work！

sandeep318kumar · 2024-10-01T11:08:50Z

@xijunmu My PR has been merged. Can you rebase your PR?

xijunmu added 2 commits September 9, 2024 15:35

1.fix jar package conflict problem

2167cb7

2.upgrade commons-io to 2.8.0 3.upgrade guava to 32.1.1-jre 4.upgrade kafka to 2.8.2 5.upgrade zookeeper to 3.7.2 6.upgrade hbase to 2.4.17 7.upgrade hadoop to 3.3.6 8.add missing jar sqlline

1.upgrade phoenix to 2.4-5.1.3

fce2cbd

2.modify download url

virajjasani approved these changes Sep 9, 2024

View reviewed changes

virajjasani reviewed Sep 9, 2024

View reviewed changes

ambari-metrics-assembly/pom.xml Outdated Show resolved Hide resolved

remove useless commented

471f4a0

vishalsuvagia reviewed Sep 22, 2024

View reviewed changes

xijunmu closed this Oct 8, 2024

xijunmu deleted the AMBARI-26131 branch October 8, 2024 07:22

xijunmu mentioned this pull request Oct 9, 2024

AMBARI-26131:Fix ambari-metrics-collector service check failed and resolve jar conflict problem #135

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AMBARI-26131:Fix ambari-metrics-collector service check failed and resolve jar conflict problem #131

AMBARI-26131:Fix ambari-metrics-collector service check failed and resolve jar conflict problem #131

xijunmu commented Sep 9, 2024

xijunmu commented Sep 9, 2024

virajjasani commented Sep 9, 2024

virajjasani commented Sep 10, 2024

JiaLiangC commented Sep 12, 2024

virajjasani commented Sep 12, 2024

JiaLiangC commented Sep 12, 2024

virajjasani commented Sep 12, 2024

vishalsuvagia Sep 22, 2024

xijunmu Sep 23, 2024

vishalsuvagia Sep 22, 2024

xijunmu Sep 23, 2024

vishalsuvagia Sep 22, 2024

virajjasani Sep 22, 2024

sandeep318kumar commented Sep 25, 2024

xijunmu commented Sep 26, 2024 •

edited

Loading

sandeep318kumar commented Sep 26, 2024

xijunmu commented Sep 27, 2024

sandeep318kumar commented Oct 1, 2024

AMBARI-26131:Fix ambari-metrics-collector service check failed and resolve jar conflict problem #131

AMBARI-26131:Fix ambari-metrics-collector service check failed and resolve jar conflict problem #131

Conversation

xijunmu commented Sep 9, 2024

What changes were proposed in this pull request?

How was this patch tested?

xijunmu commented Sep 9, 2024

virajjasani commented Sep 9, 2024

virajjasani commented Sep 10, 2024

JiaLiangC commented Sep 12, 2024

virajjasani commented Sep 12, 2024

JiaLiangC commented Sep 12, 2024

virajjasani commented Sep 12, 2024

vishalsuvagia Sep 22, 2024

Choose a reason for hiding this comment

xijunmu Sep 23, 2024

Choose a reason for hiding this comment

vishalsuvagia Sep 22, 2024

Choose a reason for hiding this comment

xijunmu Sep 23, 2024

Choose a reason for hiding this comment

vishalsuvagia Sep 22, 2024

Choose a reason for hiding this comment

virajjasani Sep 22, 2024

Choose a reason for hiding this comment

sandeep318kumar commented Sep 25, 2024

xijunmu commented Sep 26, 2024 • edited Loading

====================================================================== ERROR: TestEmitter (unittest.loader._FailedTest)

====================================================================== ERROR: TestMetricCollector (unittest.loader._FailedTest)

====================================================================== ERROR: testMemInfo (TestHostInfo.TestHostInfo)

FAILED (errors=3)

Failed tests: ERROR: TestEmitter (unittest.loader._FailedTest)

ERROR: TestMetricCollector (unittest.loader._FailedTest)

ERROR: testMemInfo (TestHostInfo.TestHostInfo)

sandeep318kumar commented Sep 26, 2024

xijunmu commented Sep 27, 2024

sandeep318kumar commented Oct 1, 2024

xijunmu commented Sep 26, 2024 •

edited

Loading

======================================================================
ERROR: TestEmitter (unittest.loader._FailedTest)

======================================================================
ERROR: TestMetricCollector (unittest.loader._FailedTest)

======================================================================
ERROR: testMemInfo (TestHostInfo.TestHostInfo)

Failed tests:
ERROR: TestEmitter (unittest.loader._FailedTest)