ARTEMIS-5215 Credit handler reset in progress flag when stopped #5480
+108
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a pull mode federation consumer is stopped due to demand being removed and the credit tup-up handler is also awaiting the Queue backlog to clear in order to grant a new batch of credit it might exit that cycle an leave the in-progress flag set to true. Currently this likely won't trigger a stuck consumer but if the code was to be altered to hold open a link for some period of time before fully closing in order to avoid needless attach / detach cycles then it would be possible for the credit replenishment to get stuck because the previous attempt left the in-progress flag set to true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a pull mode federation consumer is stopped due to demand being removed and the credit tup-up handler is also awaiting the Queue backlog to clear in order to grant a new batch of credit it might exit that cycle an leave the in-progress flag set to true. Currently this likely won't trigger a stuck consumer but if the code was to be altered to hold open a link for some period of time before fully closing in order to avoid needless attach / detach cycles then it would be possible for the credit replenishment to get stuck because the previous attempt left the in-progress flag set to true.