Merge pull request #521 from anvilistas/routing-stale-form-load

routing - fix stale form load
anvilistas · Mar 26, 2024 · bac039f · bac039f
2 parents 6070842 + 05d23b1
commit bac039f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,8 @@
   https://github.com/anvilistas/anvil-extras/issues/513
 * switch - fix lever color when switch is checked
   https://github.com/anvilistas/anvil-extras/pull/517
+* routing - fix on_form_load might fire stale value if form_show event is slow
+  https://github.com/anvilistas/anvil-extras/discussions/521
 
 ## Minor Changes
 * designer hints - add some designer hints to components

diff --git a/client_code/routing/_router.py b/client_code/routing/_router.py
@@ -170,6 +170,8 @@ def navigate(url_hash=None, url_pattern=None, url_dict=None, **properties):
             _current_form = form
             update_form_attrs(form)
             add_form_to_container(form)
+        # if the form_show was slow don't fire the on_form_load callback
+        nav_context.check_stale()
         alert_form_loaded(form=form, **url_args)