Add unit tests for pod/pod_spec/pod_temp_spec #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ZichengMa <[email protected]>
Signed-off-by: ZichengMa <[email protected]>
marshtompsxd
reviewed
Oct 2, 2023
src/kubernetes_api_objects/volume.rs
Outdated
| #[verifier(external_body)] | ||
| pub fn clone(&self) -> (volume: Volume) | ||
| ensures | ||
| volume@ == volume@, |
There was a problem hiding this comment.
postcondition is wrong
marshtompsxd
changed the title
marshtompsxd
changed the title
marshtompsxd
reviewed
Oct 2, 2023
| @@ -13,3 +13,6 @@ pub mod probe; | |||
| pub mod resource_requirements; | |||
| pub mod tcp_socket_action; | |||
| pub mod volume_mount; | |||
| pub mod pod; | |||
| pub mod pod_spec; | |||
| pub mod pod_template_spec; | |||
There was a problem hiding this comment.
You can add a new empty line at the end of file
Signed-off-by: ZichengMa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the PodSpec's tests, the Volume API is used. The unit tests for Volume will be in next PR. There are many different APIs should be tested for Volume, so I split those tests to next PR.