Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CSS import because of antdv5 CSS-in-JS #2921

Closed
wants to merge 1 commit into from

Conversation

azro352
Copy link

@azro352 azro352 commented Nov 23, 2022

Description

Due to [email protected] uses CSS-in-JS no CSS file import is needed (and in fact causing issue).
That project in a dependency of @ant-design/charts, so it's very important that this bug is fixed

Motivation and Context

Fixes #2907

Fix confirmed in ant-design/ant-design#38879

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@x6-bot
Copy link
Contributor

x6-bot bot commented Nov 23, 2022

👋 @azro352

💖 Thanks for opening this pull request! 💖

Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add graph.scale() method
  • docs: graph.getShortestPath is now available

Things that will help get your PR across the finish line:

  • Follow the TypeScript, JavaScript, CSS and React coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@x6-bot x6-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. PR: unreviewed PR does not have any reviews. pkg:x6-react-components labels Nov 23, 2022
Copy link
Contributor

@NewByVector NewByVector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First check to see if you are using 1.x or 2.x, this has been fixed in 1.1.20.
https://github.com/antvis/X6/pull/2878/files

@NewByVector
Copy link
Contributor

NewByVector commented Nov 24, 2022

Support antd5 in 2.x: #2933

@azro352
Copy link
Author

azro352 commented Nov 24, 2022

Strange that this PR doesn't show that there is no more change to apply
Thanks ! I'll close it !

@azro352 azro352 closed this Nov 24, 2022
@azro352 azro352 deleted the patch-1 branch December 8, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: unreviewed PR does not have any reviews. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[react component] antd v5 已经移除了css 支持
2 participants