- Migration of some methods to new Delphi Tokio 10.2.3

[fabianobr]

Hello Dare,

I would like to contribute some adjustments to make the project compatible with Delphi Tokyo.

Cheers

[antonio-petricca]

Hi @fabianobr , I am very happy to accept your contribution. I love very much this project. I created it to solve a real production problem at my company, and I tought it maybe useful to something else!

As you may have noted, the code quality is one of the most important thing for a good and useful code sharing, so I would ask you to review your code as I am going to show you:

1. Rearrange uses in alphabetical order (look at src/BugFinder/BugFinder.dpr, src/BugFinder/uDebugThread.pas, and src/BugFinder/ufmBugFinder.pas).
2. Class fields and Variables must be declared alphabetically and colons aligned to each other (look at src/BugFinder/uBreakpoints.pas and src/Providers/Symbols/TD32SP/JclTD32.pas).
3. Assignments must be aligned to := operator (look at src/BugFinder/uBreakpoints.pas and src/Providers/Symbols/TD32SP/JclTD32.pas).

Now please tell me in details me the benefits introduced by the improvements to the following files:

1. src/BugFinder/uBreakpoints.pas.
2. src/Providers/Symbols/TD32SP/JclTD32.pas.
3. src/Providers/Symbols/TD32SP/uJclTD32.pas.
4. src/intf/hSymProvider.pas and src/intf/uSymProvider.pas.

I have initialized the repository by Git Flow and created a feature delphi-tokio where I will merge your changes as soon as you fixed them as early explained.

Unfortunately I have no more to time to develop this project, and I do not own a Delphi Tokyo copy, so I kindly ask you the send me a compiled version of the setup in order to try on my own your updates.

When your work will be reviewed and tested I will upgrade it to 1.3.0 and I will officially release it.

Thank you so much!

Antonio

[antonio-petricca]

Hi again, as stated in my previous comment, I did for you some of the code style refactoring.

Now I ask you:

1. An explanation about what do the DebugStart, DebugEnd and Size fields.
2. A compiled setup.

Thank you!
Antonio

[fabianobr]

Hi Antonio,

I really admire your work with the Bug Finder classes, congratulations.

My goal is to make a tool to instrument any Delphi Win32 application and make it compatible with APM platforms like DataDog, New Relic, and so on ...

So in some cases I'm extracting classes in isolated units.

I will follow your recommendations soon I will send the adjustments.

Cheers!

[antonio-petricca]

Hi, how is going on?

[antonio-petricca]

Hi, are you no more interested in contributing this project?

Regards,
Antonio