feat: make nothrow() toggleable

closes google#1029
antongolub · Jan 7, 2025 · 70d166b · 70d166b
1 parent 53718a7
commit 70d166b
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/src/core.ts b/src/core.ts
@@ -501,8 +501,8 @@ export class ProcessPromise extends Promise<ProcessOutput> {
     return this
   }
 
-  nothrow(): ProcessPromise {
-    this._nothrow = true
+  nothrow(v = true): ProcessPromise {
+    this._nothrow = v
     return this
   }
 

diff --git a/test/core.test.js b/test/core.test.js
@@ -33,12 +33,14 @@ import {
 } from '../build/core.js'
 import {
   tempfile,
+  tempdir,
   fs,
   quote,
   quotePowerShell,
   sleep,
   quiet,
   which,
+  nothrow,
 } from '../build/index.js'
 
 describe('core', () => {
@@ -939,6 +941,15 @@ describe('core', () => {
     test('nothrow() does not throw', async () => {
       const { exitCode } = await $`exit 42`.nothrow()
       assert.equal(exitCode, 42)
+      {
+        // Toggle
+        try {
+          const p = $`exit 42`.nothrow()
+          await p.nothrow(false)
+        } catch ({ exitCode }) {
+          assert.equal(exitCode, 42)
+        }
+      }
       {
         // Deprecated.
         const { exitCode } = await nothrow($`exit 42`)