Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thinking about relating owned types and read items #31

Merged
merged 12 commits into from
May 28, 2024
Merged

Thinking about relating owned types and read items #31

merged 12 commits into from
May 28, 2024

Conversation

antiguru
Copy link
Owner

@antiguru antiguru commented May 25, 2024 •
edited
Loading

Adds a Owned type to Region, with the added constraint that R::ReadItem<'_>: IntoOwned<'_, R::Owned>. Also adds a IntoOwned trait that is similar to Rust's ToOwned, without the requirement that the type must also be Borrow.

antiguru added 6 commits May 27, 2024 14:17
@antiguru
WIP to think about ownership
038766b 
Signed-off-by: Moritz Hoffmann <[email protected]>
@antiguru
opinionatedregion
4aace29 
Signed-off-by: Moritz Hoffmann <[email protected]>
@antiguru
wip
55cbe25 
Signed-off-by: Moritz Hoffmann <[email protected]>
@antiguru
clone_onto take self
606a240 
Signed-off-by: Moritz Hoffmann <[email protected]>
@antiguru
All IntoOwned implemented
055b903 
Signed-off-by: Moritz Hoffmann <[email protected]>
@antiguru
Remove older experiments
b94ec0f 
Signed-off-by: Moritz Hoffmann <[email protected]>
antiguru added 2 commits May 28, 2024 13:16
@antiguru
Reborrow
6e5f732 
Signed-off-by: Moritz Hoffmann <[email protected]>
@antiguru
IntoOwned takes self by ref
1c4ee3f 
Signed-off-by: Moritz Hoffmann <[email protected]>
antiguru added 4 commits May 28, 2024 14:35
@antiguru
Revert "IntoOwned takes self by ref"
ef6fedf 
This reverts commit 1c4ee3f.
@antiguru
Add test for a new cow variant
94f03e1 
Signed-off-by: Moritz Hoffmann <[email protected]>
@antiguru
cleanup
b6f93d0 
Signed-off-by: Moritz Hoffmann <[email protected]>
@antiguru
Rust compatibility
9fc2562 
Signed-off-by: Moritz Hoffmann <[email protected]>
@antiguru antiguru marked this pull request as ready for review May 28, 2024 20:49
@antiguru antiguru merged commit 2ed1204 into main May 28, 2024
8 checks passed
@antiguru antiguru deleted the owned branch May 28, 2024 20:52
@github-actions github-actions bot mentioned this pull request May 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@antiguru