Replace CopyOnto by Push #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Moritz Hoffmann <[email protected]>
Swap the parameters for CopyOnto. Previously, we'd implement CopyOnto for a specific type, specifying the region as a parameter to CopyOnto. This has the undesired side-effect that downstream crates cannot implement the trait for their own regions due to Rust's orphan rules. Switching the parameters around (Push<T> for Region) moves a local type into the T0 position, which is compatible with the orphan rules. Similarly updates ReserveItems. Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
antiguru
changed the title
Signed-off-by: Moritz Hoffmann <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the
CopyOntotrait by aPushtrait, plus other housekeeping changes. The motivation for this is are Rust's orphan rules when implementing traits: A downstream crate can implementTrait<T> for LocalType, but notTrait<LocalType> for TwhenTraitis defined in an upstream crate. For this reason, we switch the types forCopyOntoimplementations and give it a better name.Similarly, this updates the
ReserveItemstrait suffering from the same issue.Additionally, clean up some cruft and add implementations I overlooked.