Remove CopyOnto requirement for ReadItem #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the requirement that `Region::ReadItem` implements `CopyOnto<Self>` because it infects the region with the type bounds of the specific implementation without adding much value. It still is a good idea that implementations offer this functionality, but it seems overly restrictive to enforce this property for all implementations. Signed-off-by: Moritz Hoffmann <[email protected]>
antiguru
force-pushed
the
read_item_not_copy_onto
branch
from
e2e1a7b to
7d6b218
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the requirement that
Region::ReadItemimplementsCopyOnto<Self>because it infects the region with the type bounds of the specific implementation without adding much value. It still is a good idea that implementations offer this functionality, but it seems overly restrictive to enforce this property for all implementations.cc @ParkMyCar