Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 chore: update Solidity dependencies #540

Closed
wants to merge 3 commits into from

Conversation

Sabnock01
Copy link
Contributor

@Sabnock01 Sabnock01 commented Oct 1, 2023

Removes the now deprecated remappings for Uniswap in foundry.toml.

Although it looks like forge-std isn't used anywhere either, I suppose there may be future need for it.

Update: Also pushed a commit to fix the .gitmodules which was currently missing and modified foundry.toml to use the correct import style to match contracts/.

Resolves #541

@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

Merging #540 (cc6c256) into main (7c1fba4) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #540   +/-   ##
=======================================
  Coverage   58.75%   58.75%           
=======================================
  Files          11       11           
  Lines        3722     3722           
=======================================
  Hits         2187     2187           
  Misses       1535     1535           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Sabnock01 Sabnock01 changed the title 🔧 chore: remove Uniswap remappings 🔧 chore: update Solidity dependencies Oct 1, 2023
@0xJepsen
Copy link
Collaborator

0xJepsen commented Oct 3, 2023

Shall we maybe close this in favor of #573 ?

@Sabnock01
Copy link
Contributor Author

Shall we maybe close this in favor of #573 ?

That depends on how you plan to use the contracts. Do you want them to work out of the box? The two PR's don't really overlap. #573 is basically to just get rid of warnings / errors in the Solidity files. I'll leave to your discretion.

@0xJepsen
Copy link
Collaborator

0xJepsen commented Oct 3, 2023

Shall we maybe close this in favor of #573 ?

That depends on how you plan to use the contracts. Do you want them to work out of the box? The two PR's don't really overlap. #573 is basically to just get rid of warnings / errors in the Solidity files. I'll leave to your discretion.

No we never use these contracts directly at all. We just export their bindings with the crate. We might not even ever really need the foundry.toml in this repo either.

@Sabnock01
Copy link
Contributor Author

Shall we maybe close this in favor of #573 ?

That depends on how you plan to use the contracts. Do you want them to work out of the box? The two PR's don't really overlap. #573 is basically to just get rid of warnings / errors in the Solidity files. I'll leave to your discretion.

No we never use these contracts directly at all. We just export their bindings with the crate. We might not even ever really need the foundry.toml in this repo either.

Fair enough. Will close.

@Sabnock01 Sabnock01 closed this Oct 3, 2023
@Sabnock01 Sabnock01 deleted the sabnock/fix-remappings branch October 3, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: fix foundry.toml remappings
2 participants