Bug/filter test termination #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #443 +/- ##
=======================================
Coverage 58.24% 58.24%
=======================================
Files 10 10
Lines 2996 2996
=======================================
Hits 1745 1745
Misses 1251 1251
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Closes #423 by fixing our filter watcher watcher tests that were initially commented out here:
https://github.com/primitivefinance/arbiter/blob/bb4b7af1d985739751de385336f7bdfe9058610a/arbiter-core/src/tests/interaction.rs#L104-L218
They now pass and terminate with the expected behavior. This was done by manually polling the stream and matching on the poll.