Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup custom error types #434

Merged
merged 4 commits into from
Aug 17, 2023
Merged

cleanup custom error types #434

merged 4 commits into from
Aug 17, 2023

Conversation

ts0yu
Copy link
Collaborator

@ts0yu ts0yu commented Aug 17, 2023

boom

@ts0yu ts0yu requested review from Autoparallel and 0xJepsen and removed request for Autoparallel August 17, 2023 13:08
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #434 (9c798a2) into main (12e06ee) will increase coverage by 0.41%.
Report is 1 commits behind head on main.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main     #434      +/-   ##
==========================================
+ Coverage   57.82%   58.24%   +0.41%     
==========================================
  Files          10       10              
  Lines        3028     2996      -32     
==========================================
- Hits         1751     1745       -6     
+ Misses       1277     1251      -26     
Files Changed Coverage Δ
arbiter-core/src/manager.rs 61.11% <0.00%> (+2.77%) ⬆️
arbiter-core/src/environment.rs 76.68% <39.13%> (+5.32%) ⬆️
arbiter-core/src/middleware.rs 84.52% <64.00%> (+1.14%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Autoparallel Autoparallel self-assigned this Aug 17, 2023
@Autoparallel
Copy link
Collaborator

I'll review this in a bit! Looking clean though 😁

Copy link
Collaborator

@0xJepsen 0xJepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me! If you could bump the patch version i think we can get this moved in!

Copy link
Collaborator

@Autoparallel Autoparallel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@Autoparallel
Copy link
Collaborator

@0xJepsen I bumped the arbiter-core patch since that was all that was touched. Feel free to review/merge.

@0xJepsen 0xJepsen merged commit bb4b7af into main Aug 17, 2023
5 of 6 checks passed
@0xJepsen 0xJepsen deleted the ts0yu/cleanup branch August 17, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants