Test cleanup #422
Merged
Test cleanup #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xJepsen
approved these changes
Aug 16, 2023
| @@ -129,7 +129,7 @@ pub struct Environment { | |||
|
|
|||
| /// The [`EVM`] that is used as an execution environment and database for | |||
| /// calls and transactions. | |||
| pub(crate) evm: EVM<CacheDB<EmptyDB>>, | |||
| evm: EVM<CacheDB<EmptyDB>>, | |||
There was a problem hiding this comment.
Remind me why we are doing this again.
There was a problem hiding this comment.
Because we don't actually reference the evm field of Environment anywhere else in the crate, so we are safe to keep its visibility to private. I feel it's usually good to minimize visibility to the lowest point.
| @@ -167,7 +173,7 @@ impl MiddlewareError for RevmMiddlewareError { | |||
| } | |||
|
|
|||
| fn as_inner(&self) -> Option<&Self::Inner> { | |||
| Some(self) | |||
| None | |||
There was a problem hiding this comment.
Can you explain this to me? The middleware onion has been a little black boxed for to only handle it on one layer at a time.
| @@ -308,7 +313,13 @@ impl Middleware for RevmMiddleware { | |||
| _gas_refunded: _, | |||
| logs, | |||
| output, | |||
| } = unpack_execution_result(revm_result.result)?; | |||
| } = match unpack_execution_result(revm_result.result) { | |||
There was a problem hiding this comment.
Nice i was wondering about this when i was debugging my issue
There was a problem hiding this comment.
Oh shit. I don't actually want to do it this way. Doing it with ? is better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview of tasks
RevmMiddlewareError.RevertandHalterror variants.