-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: some fun unsafe stuff #412
Conversation
https://github.com/Will-Smith11/mem-playground |
@Will-Smith11 can we meet today and talk about this? I'd like to understand how it works. Dropping our ethers fork would be hugely beneficial. I'll need one more feature than you list here, I believe. But nonetheless, this is awesome. I love to see it!! |
Removed extraneous additions. Kept in the `PendingTxState` enum in `middleware.rs` for now.
Just sent a PR into your branch @Will-Smith11 I reduced things a bit. Let's keep it going and make sure we can get this to work with the least amount of overhead and with as much compatibility as possible. |
modify `PendingTxState` directly
Your move, sir @Will-Smith11 😈 |
Got all tests to pass afterward
…s-for-environmentparams feat: derives for `EnvironmentParameters` and move label
Also cleaned up the `serde_json` import but no noticeable change from it.
…ant-seedable-feature feat: version change for `RustQuant` with "seedable" feature
…ve-environment-errors chore: improve environment errors
…type feat: block type enum
Lets be sure to actually fill out all the useful fields in the transactions receipts |
Codecov Report
@@ Coverage Diff @@
## main #412 +/- ##
==========================================
+ Coverage 58.24% 59.42% +1.18%
==========================================
Files 10 11 +1
Lines 2996 3236 +240
==========================================
+ Hits 1745 1923 +178
- Misses 1251 1313 +62
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more 📢 Have feedback on the report? Share it here. |
I am going to close this PR and Re-open it into the |
@Autoparallel Remember at ethcc when we couldn't find a way around the PendingTransaction state and you had to end up forking ethers-rs...
Well I realized I had a fix and wanted to try this. I have a local test and the code works as expected... I don't care if you merge it or not I just wanted a low level challenge and thought best case scenario I can also help someone else out.