refactor: crop circle in SVG (4/4) #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
privatenumber
force-pushed
the
separate-cropping
branch
from
5d0cfef
to
84bd8b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
This is a PR against #94
Diff: privatenumber/sponsorkit@optimize-cache-more...separate-cropping
#94 should be merged first
Description
The cropping functionality didn't really belong in the resize function, and made the resized image less re-usable
I moved the cropping logic to the SVG level so we don't need to call sharp for every avatar we want to crop into a circle
It's a subtle difference but the crop is cleaner now too
Before
After
Linked Issues
Additional context