Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test utils to use an interface instead of *testing.T #212

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bt
Copy link

@bt bt commented Apr 23, 2017

I'm using Ginkgo as a testing framework and I noticed that it doesn't directly plug into Ginkgo because Ginkgo will not directly expose the *testing.T in it's tests.

By using an interface, TestReporter (similar to how gomock works), we can then leverage GinkgoT() with the test.RunReporter function, like such:

test.RunRequest(GinkgoT(), api.MakeHandler(), test.MakeSimpleRequest("GET", "/version", nil))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants