Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request body discard added #183

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Request body discard added #183

wants to merge 1 commit into from

Conversation

JekaMas
Copy link

@JekaMas JekaMas commented Mar 1, 2016

Good day to you!
We have couple of errors in prod because of DecodeJsonPayload doesn`t discard the remaining response body data in 100% cases. It should be done in GO 1.5+

@ChrisLundquist
Copy link

Nice!

@ant0ine
Copy link
Owner

ant0ine commented Apr 10, 2016

Hi!

Thanks for your Pull Request! And sorry for my very slow response.
Do you have any reference to this bug I could add in comment ?
Is it the way it was fixed in go1.5 ? Or do you think that fix should be enabled only for some version of Go by checking runtime.Version() ?

Antoine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants