Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Analysis.update_component_failure_mechanism_analysis_props() #478

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ansjmoody
Copy link
Collaborator

Description

Add Analysis.update_component_failure_mechanism_analysis_props()

Issue linked

#475

Checklist:

  • Run unit tests and make sure they all pass
    - Run tests without Sherlock running
    - Run tests with Sherlock GRPC connection
  • Check and fix style errors
    - pre-commit command line check
    - Problems tab in PyCharm
  • Bench test new/modified APIs by using and modifying the code in the example for the API method
  • Add new classes to rst files, located at: \doc\source\api
  • Generate documentation
  • Verify the HTML. It gets generated at: \doc\build\html.
    - Open index.html
    - Click on "API Reference" at the top.
    - Verify HTML for API changes.
  • Check that test code coverage is at least 80% when Sherlock is running
  • Make sure that the title of the pull request follows Commit naming conventions (e.g. feat: adding new PySherlock command)

@ansjmoody ansjmoody added the enhancement New features or code improvements label Dec 20, 2024
@ansjmoody ansjmoody added this to the v0.9.0 milestone Dec 20, 2024
@ansjmoody ansjmoody self-assigned this Dec 20, 2024
@github-actions github-actions bot added testing Anything related to tests dependencies Related with project dependencies documentation Improvements or additions to documentation maintenance Package and maintenance related labels Dec 20, 2024
@ansjmoody ansjmoody requested a review from anskhanson December 20, 2024 20:29
@ansjmoody ansjmoody added dependencies Related with project dependencies and removed maintenance Package and maintenance related dependencies Related with project dependencies labels Dec 20, 2024
@github-actions github-actions bot added the maintenance Package and maintenance related label Dec 20, 2024
@ansjmoody ansjmoody enabled auto-merge (squash) December 20, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Related with project dependencies documentation Improvements or additions to documentation enhancement New features or code improvements maintenance Package and maintenance related testing Anything related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants