Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Updated documentation in update potting region. #477

Merged
merged 4 commits into from
Jan 15, 2025

Conversation

anskhanson
Copy link
Collaborator

Description

Updated example for update potting region.

Issue linked

Update potting region example is incorrect #476

Checklist:

  • [n/a] Run unit tests and make sure they all pass
    - Run tests without Sherlock running
    - Run tests with Sherlock GRPC connection
  • [n/a] Check and fix style errors
    - pre-commit command line check
    - Problems tab in PyCharm
  • [n/a] Bench test new/modified APIs by using and modifying the code in the example for the API method
  • [n/a] Add new classes to rst files, located at: \doc\source\api
  • Generate documentation
  • Verify the HTML. It gets generated at: \doc\build\html.
    - Open index.html
    - Click on "API Reference" at the top.
    - Verify HTML for API changes.
  • [n/a] Check that test code coverage is at least 80% when Sherlock is running
  • Make sure that the title of the pull request follows Commit naming conventions (e.g. feat: adding new PySherlock command)

@anskhanson anskhanson self-assigned this Dec 20, 2024
@anskhanson anskhanson requested a review from ansjmoody December 20, 2024 19:19
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 20, 2024
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.07%. Comparing base (3a358f9) to head (828acc7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #477   +/-   ##
=======================================
  Coverage   60.07%   60.07%           
=======================================
  Files          21       21           
  Lines        5009     5009           
=======================================
  Hits         3009     3009           
  Misses       2000     2000           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ansjmoody ansjmoody modified the milestone: v0.9.0 Dec 20, 2024
@ansjmoody
Copy link
Collaborator

After this is completed, this commit should be cherry picked to the release/0.8 branch.

src/ansys/sherlock/core/layer.py Show resolved Hide resolved
src/ansys/sherlock/core/layer.py Outdated Show resolved Hide resolved
@ansjmoody ansjmoody added this to the v0.9.0 milestone Jan 15, 2025
@anskhanson anskhanson force-pushed the keith/fix_update_potting_region_example branch from 50c577d to 82183d9 Compare January 15, 2025 21:55
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Jan 15, 2025
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 15, 2025
@ansjmoody ansjmoody merged commit 6227ba1 into main Jan 15, 2025
29 checks passed
@ansjmoody ansjmoody deleted the keith/fix_update_potting_region_example branch January 15, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants