Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: conf.py issue #467

Merged
merged 3 commits into from
Dec 9, 2024
Merged

fix: conf.py issue #467

merged 3 commits into from
Dec 9, 2024

Conversation

ansnfernand
Copy link
Collaborator

Description

The version in the GitHub link was wrong.

Checklist:

  • [] Run unit tests and make sure they all pass
    - Run tests without Sherlock running
    - Run tests with Sherlock GRPC connection
  • [] Check and fix style errors
    - pre-commit command line check
    - Problems tab in PyCharm
  • [] Bench test new/modified APIs by using and modifying the code in the example for the API method
  • [] Add new classes to rst files, located at: \doc\source\api
  • [] Generate documentation
  • [] Verify the HTML. It gets generated at: \doc\build\html.
    - Open index.html
    - Click on "API Reference" at the top.
    - Verify HTML for API changes.
  • [] Check that test code coverage is at least 80% when Sherlock is running
  • Make sure that the title of the pull request follows Commit naming conventions (e.g. feat: adding new PySherlock command)

@ansnfernand ansnfernand added the bug Something isn't working label Dec 9, 2024
@ansnfernand ansnfernand added this to the v0.8.0 milestone Dec 9, 2024
@ansnfernand ansnfernand self-assigned this Dec 9, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 9, 2024
@ansnfernand ansnfernand force-pushed the nayane/fix-conf-issue branch from 14f2ebe to 471e1a3 Compare December 9, 2024 13:57
@ansnfernand ansnfernand merged commit 4482106 into main Dec 9, 2024
23 of 26 checks passed
@ansnfernand ansnfernand deleted the nayane/fix-conf-issue branch December 9, 2024 14:03
ansjmoody pushed a commit that referenced this pull request Dec 9, 2024
Co-authored-by: pyansys-ci-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants