generated from ansys/template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add type hints #454
Merged
Merged
feat: add type hints #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s. Added type constants to RunStrainMapAnalysisrequestAnalysisType. Add API docs for analysis types. Fix warnings for type hints in analysis.py.
github-actions
bot
added
testing
Anything related to tests
documentation
Improvements or additions to documentation
labels
Nov 21, 2024
ansjmoody
commented
Nov 21, 2024
Closed
ansjmoody
commented
Nov 21, 2024
ansjmoody
commented
Nov 21, 2024
ansjmoody
force-pushed
the
add_type_hints
branch
from
November 21, 2024 22:56
fa6b403
to
89dc207
Compare
ansjmoody
commented
Nov 22, 2024
ansjmoody
commented
Nov 22, 2024
ansjmoody
commented
Nov 22, 2024
…le back to where it was originally
ansjmoody
assigned anskhanson and ansnfernand and unassigned anskhanson and ansnfernand
Nov 22, 2024
…eFile constructor
…hat is failing due to forward declarations
ansjmoody
commented
Dec 3, 2024
anskhanson
approved these changes
Dec 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Related with project dependencies
documentation
Improvements or additions to documentation
maintenance
Package and maintenance related
testing
Anything related to tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please provide a brief description of the changes made in this pull request.
Add type hints to all source code. Update parameter types in comments to match.
Consistent formatting for commented parameter descriptions.
Updated rst files to include more classes.
Added SherlockNoGrpcConnectionException and raise this exception when there is no GRPC connection.
Fix and reduce warnings.
Fix bug when setting enum values in Analysis.update_pcb_modeling_props().
Use type constants instead of strings in examples and unit tests.
Removed "List of" in the parameter documentation description for collections. Sometimes the type isn't a list so this wording can be confusing.
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist:
- Run tests without Sherlock running
- Run tests with Sherlock GRPC connection
- pre-commit command line check
- Problems tab in PyCharm
- Open index.html
- Click on "API Reference" at the top.
- Verify HTML for API changes.
feat: adding new PySherlock command
)