generated from ansys/template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding version check to all API methods #440
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
testing
Anything related to tests
dependencies
Related with project dependencies
maintenance
Package and maintenance related
documentation
Improvements or additions to documentation
labels
Nov 5, 2024
github-actions
bot
removed
dependencies
Related with project dependencies
maintenance
Package and maintenance related
labels
Nov 5, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #440 +/- ##
==========================================
+ Coverage 56.93% 57.91% +0.97%
==========================================
Files 21 23 +2
Lines 4742 4878 +136
==========================================
+ Hits 2700 2825 +125
- Misses 2042 2053 +11 ☔ View full report in Codecov by Sentry. |
anskhanson
changed the title
Adding version check to all API methods
feat: Adding version check to all API methods
Nov 6, 2024
ansjmoody
requested changes
Nov 6, 2024
anskhanson
force-pushed
the
keith/versioning
branch
from
November 7, 2024 15:41
d015663
to
1f52446
Compare
…t set. Otherwise it was getting set to current version which might be before the min_version.
… the new changes, rather than always the latest version. Client used to raise 2 exceptions if Sherlock did not start. One was for sherlock not starting and another was that it was unable to connect to Sherlock. Now it will raise 1 exception. If Sherlock cannot start it will raise that exception. If Sherlock starts but PySherlock cannot connect it will raise that exception.
…n previously what the decorator had listed.
anskhanson
force-pushed
the
keith/versioning
branch
from
November 7, 2024 20:30
2e1d502
to
90e3d4e
Compare
ansjmoody
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
- Run tests without Sherlock running
- Run tests with Sherlock GRPC connection
- pre-commit command line check
- Problems tab in PyCharm
- Open index.html
- Click on "API Reference" at the top.
- Verify HTML for API changes.