Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New api: updatePartsListProperties() #235

Merged
merged 6 commits into from
Mar 6, 2024
Merged

Conversation

ansnfernand
Copy link
Collaborator

Checklist:

  • Run unit tests and make sure they all pass
  • Check and fix style errors
    - pre-commit command line check
    - Problems tab in PyCharm
  • Bench test new/modified APIs by using and modifying the code in the example for the API method
  • n/a Add new classes to rst files, located at: \doc\source\api
  • Generate documentation
  • Verify the HTML. It gets generated at: \doc\build\html.
    - Open index.html
    - Click on "API Reference" at the top.
    - Verify HTML for API changes.
  • Check that test code coverage is at least 80% when Sherlock is running and can be connected to using gRPC

@ansnfernand ansnfernand requested a review from ansjmoody March 1, 2024 13:00
src/ansys/sherlock/core/parts.py Outdated Show resolved Hide resolved
src/ansys/sherlock/core/parts.py Outdated Show resolved Hide resolved
src/ansys/sherlock/core/parts.py Outdated Show resolved Hide resolved
src/ansys/sherlock/core/parts.py Outdated Show resolved Hide resolved
src/ansys/sherlock/core/parts.py Outdated Show resolved Hide resolved
tests/test_parts.py Show resolved Hide resolved
src/ansys/sherlock/core/parts.py Outdated Show resolved Hide resolved
tests/test_parts.py Outdated Show resolved Hide resolved
tests/test_parts.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 57.89474% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 57.30%. Comparing base (6ce4e96) to head (4cf1d3f).

❗ Current head 4cf1d3f differs from pull request most recent head fe7ecf6. Consider uploading reports for the commit fe7ecf6 to get more accurate results

Files Patch % Lines
src/ansys/sherlock/core/parts.py 52.08% 23 Missing ⚠️
src/ansys/sherlock/core/errors.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #235   +/-   ##
=======================================
  Coverage   57.29%   57.30%           
=======================================
  Files          21       21           
  Lines        3646     3703   +57     
=======================================
+ Hits         2089     2122   +33     
- Misses       1557     1581   +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/ansys/sherlock/core/parts.py Outdated Show resolved Hide resolved
src/ansys/sherlock/core/parts.py Outdated Show resolved Hide resolved
src/ansys/sherlock/core/parts.py Outdated Show resolved Hide resolved
tests/test_parts.py Outdated Show resolved Hide resolved
tests/test_parts.py Outdated Show resolved Hide resolved
tests/test_parts.py Outdated Show resolved Hide resolved
@ansnfernand ansnfernand enabled auto-merge (squash) March 6, 2024 16:50
@ansnfernand ansnfernand merged commit 7c41058 into main Mar 6, 2024
24 checks passed
@ansnfernand ansnfernand deleted the updatePartsListProperties branch March 6, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants