Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: launch_gui command #882

Merged
merged 42 commits into from
Sep 16, 2024
Merged

feat: launch_gui command #882

merged 42 commits into from
Sep 16, 2024

Conversation

klmcadams
Copy link
Collaborator

  • Users can call app.launch_gui() to launch their current project in graphical mode
  • Uses subprocess.Popen to launch the GUI using the command line given the temporary project file and version of the project

@klmcadams klmcadams requested a review from a team as a code owner August 26, 2024 19:54
@klmcadams klmcadams marked this pull request as draft August 26, 2024 19:54
@github-actions github-actions bot added the enhancement New features or code improvements label Aug 26, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 26, 2024
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 93.54839% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.04%. Comparing base (7ea9219) to head (cba9ec5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #882      +/-   ##
==========================================
+ Coverage   80.61%   81.04%   +0.42%     
==========================================
  Files          33       35       +2     
  Lines        2167     2226      +59     
==========================================
+ Hits         1747     1804      +57     
- Misses        420      422       +2     

@klmcadams klmcadams marked this pull request as ready for review September 11, 2024 20:31
src/ansys/mechanical/core/embedding/ui.py Outdated Show resolved Hide resolved
tests/embedding/test_app.py Show resolved Hide resolved
tests/embedding/test_app.py Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
tests/embedding/test_app.py Outdated Show resolved Hide resolved
tests/embedding/test_app.py Outdated Show resolved Hide resolved
@klmcadams klmcadams requested a review from koubaa September 13, 2024 16:41
tests/embedding/test_app.py Show resolved Hide resolved
@klmcadams klmcadams requested a review from koubaa September 13, 2024 19:22
@klmcadams klmcadams enabled auto-merge (squash) September 13, 2024 19:29
@klmcadams klmcadams merged commit 7d565d6 into main Sep 16, 2024
49 checks passed
@klmcadams klmcadams deleted the feat/gui-on-load branch September 16, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Related with project dependencies documentation Improvements or additions to documentation enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants