Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Integrate ansys visualization tool #846

Merged
merged 5 commits into from
Aug 2, 2024
Merged

Feat: Integrate ansys visualization tool #846

merged 5 commits into from
Aug 2, 2024

Conversation

dipinknair
Copy link
Collaborator

  • Integrate ansys-visualization tool

@dipinknair dipinknair requested a review from a team as a code owner July 31, 2024 14:47
@github-actions github-actions bot added dependencies Related with project dependencies enhancement New features or code improvements labels Jul 31, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 31, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 31, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 81.74%. Comparing base (9016a97) to head (6fa3dee).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #846      +/-   ##
==========================================
- Coverage   81.91%   81.74%   -0.17%     
==========================================
  Files          32       32              
  Lines        2101     2104       +3     
==========================================
- Hits         1721     1720       -1     
- Misses        380      384       +4

AlejandroFernandezLuces
AlejandroFernandezLuces requested changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@AlejandroFernandezLuces AlejandroFernandezLuces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🙂

A couple of minor changes, let me know when you fix them.

src/ansys/mechanical/core/embedding/viz/embedding_plotter.py Outdated Show resolved Hide resolved
src/ansys/mechanical/core/embedding/app.py Outdated Show resolved Hide resolved
src/ansys/mechanical/core/embedding/app.py Show resolved Hide resolved
src/ansys/mechanical/core/embedding/app.py Show resolved Hide resolved
@dipinknair
Copy link
Collaborator Author

Great work 🙂

A couple of minor changes, let me know when you fix them.

Thanks for reviewing. I have updated the comments. Please re review

@dipinknair dipinknair linked an issue Aug 1, 2024 that may be closed by this pull request
Add ansys-tools-visualization-interface for plotting #781
Closed
AlejandroFernandezLuces
AlejandroFernandezLuces approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@AlejandroFernandezLuces AlejandroFernandezLuces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@dipinknair dipinknair merged commit 02a6566 into main Aug 2, 2024
29 of 31 checks passed
@dipinknair dipinknair deleted the feat/avti branch August 2, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlejandroFernandezLuces AlejandroFernandezLuces AlejandroFernandezLuces approved these changes

@koubaa koubaa koubaa approved these changes

Assignees
No one assigned
Labels
dependencies Related with project dependencies documentation Improvements or additions to documentation enhancement New features or code improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ansys-tools-visualization-interface for plotting
4 participants
@dipinknair @koubaa @AlejandroFernandezLuces @pyansys-ci-bot