chore: code maintenance (#949)

Co-authored-by: pyansys-ci-bot <[email protected]>

CODE_OF_CONDUCT.md

@@ -57,9 +57,9 @@ further defined and clarified by project maintainers.
 
 This Code of Conduct is adapted from the [Contributor Covenant][homepage],
 version 1.4, available at
-https://www.contributor-covenant.org/version/1/4/code-of-conduct.html
+<https://www.contributor-covenant.org/version/1/4/code-of-conduct.html>
 
 [homepage]: https://www.contributor-covenant.org
 
 For answers to common questions about this code of conduct, see
-https://www.contributor-covenant.org/faq
+<https://www.contributor-covenant.org/faq>

doc/changelog.d/949.maintenance.md

@@ -0,0 +1 @@
+code maintenance

src/ansys/mechanical/core/mechanical.py

@@ -496,7 +496,6 @@ def version(self) -> str:
                 raise
             finally:
                 self._disable_logging = False
-                pass
         return self._version
 
     @property

src/ansys/mechanical/core/pool.py

@@ -180,7 +180,7 @@ def __init__(
                     version = kwargs["version"]
                     self._remote = True
                 else:
-                    raise "Pypim is configured. But version is not passed."
+                    raise ValueError("Pypim is configured, but version is not passed.")
             else:  # get default executable
                 exec_file = get_mechanical_path()
                 if exec_file is None:  # pragma: no cover

tests/test_logging.py

@@ -165,9 +165,12 @@ def test_global_logger_debug_mode():
 @pytest.mark.remote_session_launch
 def test_global_logger_exception_handling(caplog):
     exc = "Unexpected exception"
-    with pytest.raises(Exception):
-        raise Exception(exc)
-        assert exc in caplog.text
+    with caplog.at_level(logging.ERROR):
+        with pytest.raises(Exception):
+            LOG.error(exc)  # Log the exception before raising
+            raise Exception(exc)
+
+    assert exc in caplog.text
 
 
 @pytest.mark.remote_session_launch

tests/test_mechanical.py

@@ -424,12 +424,6 @@ def test_close_all_Local_instances(tmpdir):
         assert value not in pymechanical.LOCAL_PORTS
 
 
-@pytest.mark.remote_session_launch
-def test_launch_result_mode(mechanical_result):
-    result = mechanical_result.run_python_script("2+3")
-    assert result == "5"
-
-
 @pytest.mark.remote_session_launch
 def test_find_mechanical_path():
     if pymechanical.mechanical.get_start_instance():