Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/examples #215

Merged
merged 11 commits into from
Jan 8, 2025
Merged

Feat/examples #215

merged 11 commits into from
Jan 8, 2025

Conversation

margalva
Copy link
Collaborator

@margalva margalva commented Jan 6, 2025

Add mechanism to get files for examples from the web github repo. Create test for it and redesign documentation to not require files on disk.

@margalva margalva enabled auto-merge (squash) January 6, 2025 21:57
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 87.71930% with 7 lines in your changes missing coverage. Please review.

Project coverage is 83.45%. Comparing base (732cbb7) to head (d11fce2).

Files with missing lines Patch % Lines
.../ansys/dynamicreporting/core/examples/downloads.py 87.27% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #215      +/-   ##
==========================================
+ Coverage   83.40%   83.45%   +0.04%     
==========================================
  Files          17       19       +2     
  Lines        5315     5372      +57     
==========================================
+ Hits         4433     4483      +50     
- Misses        882      889       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@zhang-yuanrui zhang-yuanrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestion

@margalva margalva merged commit 02f2c48 into main Jan 8, 2025
23 checks passed
@margalva margalva deleted the feat/examples branch January 8, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants