Add contact result properties #1961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1961 +/- ##
==========================================
- Coverage 88.42% 88.37% -0.06%
==========================================
Files 89 89
Lines 10265 10251 -14
==========================================
- Hits 9077 9059 -18
- Misses 1188 1192 +4 |
cbellot000
approved these changes
Dec 17, 2024
|
Hi @cbellot000 should this dictionary even exist? Shouldn't that information be given by the server? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required so that force_elemental_nodal is correctly computed for contact results in pydpf-post. As far as I can see this dictionary is only used to lookup metadata on request and does not impact the available results directly. The scripting name is taken from dataProcessingDoc.html in the dpf core repo.