-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pyflakes style #1953
base: master
Are you sure you want to change the base?
fix: pyflakes style #1953
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1953 +/- ##
==========================================
- Coverage 88.41% 87.35% -1.07%
==========================================
Files 89 89
Lines 10258 10248 -10
==========================================
- Hits 9070 8952 -118
- Misses 1188 1296 +108 |
7f1efc2
to
8a796f2
Compare
8a796f2
to
b6d27b1
Compare
Checking the decrease in coverage. Some tests were duplicated and exactly the same. |
a9cd044
to
cf892ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test slightly differs from another named exactly the same within this file. To be reviewed...
cf892ad
to
05c4f74
Compare
Progress on this for the next days:
This solves the issues for coverage and codacy. Example: mesh = Object.mesh
assert np.assert_allclose(mesh, mesh_expected, atol, rtol) |
I do not see how we can boost coverage on the erring lines. Most are modified f-strings or exception statements. If the lines are really being covered before now, there is no reason why they shouldn't be covered after the changes, at least I can't think of any. |
This is related with #296. It enables the PyFlakes (F) rule. Most of the changes include:
__all__
in__init__
files