Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.13 support, drop 3.9 #546

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

greschd
Copy link
Member

@greschd greschd commented Nov 27, 2024

Remove the upper bound of the supported Python version, since that makes it tedious to add new versions: PyDPF Composites needs to be released before we can update PyACP, for example.

Add Python 3.13 to the explicitly supported versions in the trove classifiers, and add it to the test matrix.

Drop support for Python 3.9.

Run pyupgrade with the --py310-plus flag, and remove the now unused imports.

Skip PyVista release 0.44.2, since it declares an incompatibility with VTK 9.4.0 which adds Python 3.13 support.

@wiz-inc-572fc38784
Copy link

wiz-inc-572fc38784 bot commented Nov 27, 2024

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities
Data Finding Sensitive Data
Secret Finding Secrets
IaC Misconfiguration IaC Misconfigurations
Total

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

@github-actions github-actions bot added maintenance Package and maintenance related dependencies Related with project dependencies labels Nov 27, 2024
@greschd greschd force-pushed the maint/update_supported_python_versions branch from 594f995 to 3d25da0 Compare November 27, 2024 10:56
Remove the upper bound of the supported Python version, since that
makes it tedious to add new versions: PyDPF Composites needs to
be released before we can update PyACP, for example.

Add Python 3.13 to the explicitly supported versions in the
trove classifiers, and add it to the test matrix.

Drop support for Python 3.9.

Run pyupgrade with the '--py310-plus' flag, and remove the now
unused imports.
@greschd greschd force-pushed the maint/update_supported_python_versions branch from 3d25da0 to 832dbdd Compare November 27, 2024 11:00
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 98.50746% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.49%. Comparing base (6bb6605) to head (11466b6).

Files with missing lines Patch % Lines
...ites/server_helpers/_connect_to_or_start_server.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #546      +/-   ##
==========================================
- Coverage   91.50%   91.49%   -0.02%     
==========================================
  Files          50       50              
  Lines        3355     3350       -5     
==========================================
- Hits         3070     3065       -5     
  Misses        285      285              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@greschd
Copy link
Member Author

greschd commented Nov 27, 2024

Waiting on a release of PyVista which does not lock VTK to <9.4.0. We could pin an older PyVista, but that's not worth it IMO.

@greschd greschd enabled auto-merge (squash) December 4, 2024 12:32
pyproject.toml Show resolved Hide resolved
@greschd greschd merged commit 92aadc5 into main Dec 4, 2024
28 checks passed
@greschd greschd deleted the maint/update_supported_python_versions branch December 4, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Related with project dependencies maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants