Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc/cyclic symmetry #517

Merged
merged 41 commits into from
Sep 18, 2024
Merged

Doc/cyclic symmetry #517

merged 41 commits into from
Sep 18, 2024

Conversation

roosre
Copy link
Collaborator

@roosre roosre commented Sep 13, 2024

Add an example to demonstrate that pyDPF Composites can be used for results of cyclic symmetry analyses as well.

While playing with the cyclic symmetry model and going through the DPF Core examples, I figured out that the RST streams provider is often used. Therefore, I thought it makes sense to expose it through a method. Let me know if you have objections.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 13, 2024
@roosre roosre marked this pull request as draft September 13, 2024 13:07
@roosre roosre requested a review from nshum4 September 13, 2024 13:17
@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.62%. Comparing base (e44f311) to head (5474d85).

Files with missing lines Patch % Lines
...sys/dpf/composites/_composite_model_impl_2023r2.py 50.00% 1 Missing ⚠️
src/ansys/dpf/composites/composite_model.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #517      +/-   ##
==========================================
- Coverage   91.66%   91.62%   -0.05%     
==========================================
  Files          50       50              
  Lines        3397     3401       +4     
==========================================
+ Hits         3114     3116       +2     
- Misses        283      285       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roosre roosre marked this pull request as ready for review September 13, 2024 13:47
@roosre roosre enabled auto-merge (squash) September 18, 2024 12:38
@roosre roosre merged commit cfa6929 into main Sep 18, 2024
21 checks passed
@roosre roosre deleted the doc/cyclic_symmetry branch September 18, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants