-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc/cyclic symmetry #517
Merged
Merged
Doc/cyclic symmetry #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
Improvements or additions to documentation
label
Sep 13, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #517 +/- ##
==========================================
- Coverage 91.66% 91.62% -0.05%
==========================================
Files 50 50
Lines 3397 3401 +4
==========================================
+ Hits 3114 3116 +2
- Misses 283 285 +2 ☔ View full report in Codecov by Sentry. |
nshum4
reviewed
Sep 13, 2024
nshum4
reviewed
Sep 13, 2024
nshum4
reviewed
Sep 13, 2024
nshum4
reviewed
Sep 13, 2024
nshum4
reviewed
Sep 13, 2024
nshum4
reviewed
Sep 13, 2024
nshum4
reviewed
Sep 13, 2024
nshum4
approved these changes
Sep 16, 2024
nshum4
reviewed
Sep 16, 2024
Co-authored-by: Nellie Shum <[email protected]>
greschd
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an example to demonstrate that pyDPF Composites can be used for results of cyclic symmetry analyses as well.
While playing with the cyclic symmetry model and going through the DPF Core examples, I figured out that the RST streams provider is often used. Therefore, I thought it makes sense to expose it through a method. Let me know if you have objections.