Improve the handling of missing materials #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roosre
commented
Jun 17, 2024
greschd
approved these changes
Jun 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #474 +/- ##
=======================================
Coverage 92.21% 92.21%
=======================================
Files 50 50
Lines 3351 3352 +1
=======================================
+ Hits 3090 3091 +1
Misses 261 261 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADO BUG 1060154
It could happen that Mechanical adds materials to the MAPDL model. For instance for flexible remote points. These materials are not present in the ENGD file. Instead of throwing an error, empty materials are added to the material provider if the new input pint "skip_missing_materials" is equals True. The failure operator will throw an error because of missing properties if such a material is used during the computation.