Fix bug while processing ACP's imported solid models #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janvonrickenbach
approved these changes
Jun 11, 2024
greschd
approved these changes
Jun 11, 2024
PipKat
reviewed
Jun 11, 2024
PipKat
reviewed
Jun 11, 2024
PipKat
reviewed
Jun 11, 2024
Co-authored-by: Kathy Pippert <[email protected]>
…pydpf-composites into bug/imported_solid_models
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #469 +/- ##
=======================================
Coverage 92.20% 92.21%
=======================================
Files 50 50
Lines 3348 3351 +3
=======================================
+ Hits 3087 3090 +3
Misses 261 261 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analysis plies of imported solid models can be linked to homogeneous elements only. They are called filler plies.
These analysis plies caused an error during the initialization of the the composite model.
In detail, the function
get_analysis_ply_index_to_name_mapignores now the filler plies which are linked to homogeneous elements only.In addition, two unit tests where added to ensure that imported solid models can be post-processed, and that ply-wise scoping is supported.