-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide access to the ply type parameter of the materials #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract some helper functions from _composites/_composite_model_impl.py and move to a separate file
roosre
commented
May 31, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #465 +/- ##
==========================================
+ Coverage 92.13% 92.20% +0.07%
==========================================
Files 49 50 +1
Lines 3304 3348 +44
==========================================
+ Hits 3044 3087 +43
- Misses 260 261 +1 ☔ View full report in Codecov by Sentry. |
janvonrickenbach
requested changes
Jun 3, 2024
greschd
approved these changes
Jun 3, 2024
Co-authored-by: Dominik Gresch <[email protected]>
…sites into feat/ply_types
github-actions
bot
added
the
documentation
Improvements or additions to documentation
label
Jun 3, 2024
cosmetic changes
janvonrickenbach
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
enhancement
New features or code improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional changes: extract helper functions from _composites/_composite_model_impl.py and move to a separate file _composite_model_helpers.py