Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide access to the ply type parameter of the materials #465

Merged
merged 16 commits into from
Jun 4, 2024

Conversation

roosre
Copy link
Collaborator

@roosre roosre commented May 28, 2024

Additional changes: extract helper functions from _composites/_composite_model_impl.py and move to a separate file _composite_model_helpers.py

Extract some helper functions from _composites/_composite_model_impl.py and move to a separate file
@github-actions github-actions bot added the enhancement New features or code improvements label May 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 31, 2024

Codecov Report

Attention: Patch coverage is 94.84536% with 5 lines in your changes missing coverage. Please review.

Project coverage is 92.20%. Comparing base (7786a12) to head (a8b876c).

Files Patch % Lines
...ys/dpf/composites/_composite_model_impl_helpers.py 94.00% 3 Missing ⚠️
src/ansys/dpf/composites/_composite_model_impl.py 95.65% 1 Missing ⚠️
...sys/dpf/composites/_composite_model_impl_2023r2.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #465      +/-   ##
==========================================
+ Coverage   92.13%   92.20%   +0.07%     
==========================================
  Files          49       50       +1     
  Lines        3304     3348      +44     
==========================================
+ Hits         3044     3087      +43     
- Misses        260      261       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 3, 2024
@roosre roosre requested a review from janvonrickenbach June 3, 2024 20:30
@roosre roosre enabled auto-merge (squash) June 4, 2024 09:53
@roosre roosre merged commit e0508f1 into main Jun 4, 2024
25 checks passed
@roosre roosre deleted the feat/ply_types branch June 4, 2024 10:20
@roosre roosre mentioned this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants