Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Numpy is already imported at the top of the module. #1604

Merged
merged 4 commits into from
Dec 27, 2024

Conversation

MaxJPRey
Copy link
Contributor

Description

As title says.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@MaxJPRey MaxJPRey requested a review from a team as a code owner December 26, 2024 18:31
@MaxJPRey MaxJPRey requested a review from RobPasMue December 26, 2024 18:31
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.28%. Comparing base (15ef7cf) to head (e902f18).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1604      +/-   ##
==========================================
- Coverage   91.28%   91.28%   -0.01%     
==========================================
  Files          86       86              
  Lines        7104     7103       -1     
==========================================
- Hits         6485     6484       -1     
  Misses        619      619              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, must be some old impl. thanks!

@RobPasMue RobPasMue enabled auto-merge (squash) December 27, 2024 08:42
@RobPasMue RobPasMue merged commit cc31b93 into main Dec 27, 2024
47 of 48 checks passed
@RobPasMue RobPasMue deleted the chore/numpy_trapezoid branch December 27, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants