Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make_child_logger only takes 2 args. #1603

Merged
merged 2 commits into from
Dec 27, 2024
Merged

fix: make_child_logger only takes 2 args. #1603

merged 2 commits into from
Dec 27, 2024

Conversation

MaxJPRey
Copy link
Contributor

Description

Too many positional args were provided to make_child_logger.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@MaxJPRey MaxJPRey requested a review from a team as a code owner December 26, 2024 18:22
@github-actions github-actions bot added the bug Something isn't working label Dec 26, 2024
@MaxJPRey MaxJPRey requested a review from RobPasMue December 26, 2024 18:32
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.28%. Comparing base (b23dcf0) to head (e4902ec).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/geometry/core/logger.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1603   +/-   ##
=======================================
  Coverage   91.28%   91.28%           
=======================================
  Files          86       86           
  Lines        7104     7104           
=======================================
  Hits         6485     6485           
  Misses        619      619           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks @MaxJPRey

@RobPasMue RobPasMue merged commit 15ef7cf into main Dec 27, 2024
49 of 50 checks passed
@RobPasMue RobPasMue deleted the fix/logger branch December 27, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants