Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: skip unnecessary stages when containers are the same #1592

Merged
merged 16 commits into from
Dec 18, 2024

Conversation

RobPasMue
Copy link
Member

@RobPasMue RobPasMue commented Dec 18, 2024

Description

Looking into saving resources... whenever the manifests for the unstable and stable images are the same, we should try to skip the execution of the unstable ones... no added value and really just consuming resources. Since we are low on VMs currently, we really need to look into saving as much as possible

Issue linked

None

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@github-actions github-actions bot added the maintenance Package and maintenance related label Dec 18, 2024
@RobPasMue RobPasMue self-assigned this Dec 18, 2024
@RobPasMue RobPasMue marked this pull request as ready for review December 18, 2024 11:48
@RobPasMue RobPasMue requested a review from a team as a code owner December 18, 2024 11:48
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.61%. Comparing base (f7a10a4) to head (4f29d9c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1592   +/-   ##
=======================================
  Coverage   91.61%   91.61%           
=======================================
  Files          86       86           
  Lines        7064     7064           
=======================================
  Hits         6472     6472           
  Misses        592      592           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue RobPasMue merged commit 9f07547 into main Dec 18, 2024
52 of 65 checks passed
@RobPasMue RobPasMue deleted the ci/skip-unnecessary-stages branch December 18, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants