Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable prepare and repair tools in Core Service #1580

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

RobPasMue
Copy link
Member

Description

Enabling prepare and repair tools in Core Service

Issue linked

Closes #1579

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Dec 10, 2024
@RobPasMue RobPasMue requested a review from a team as a code owner December 10, 2024 16:07
@github-actions github-actions bot added the enhancement New features or code improvements label Dec 10, 2024
Copy link
Contributor

@b-matteo b-matteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @RobPasMue, thanks for getting that in!

@RobPasMue
Copy link
Member Author

Looks like that the repair tools are not ready...

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.64%. Comparing base (719b892) to head (459fb86).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/geometry/core/modeler.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1580      +/-   ##
==========================================
+ Coverage   91.61%   91.64%   +0.02%     
==========================================
  Files          86       86              
  Lines        7064     7062       -2     
==========================================
  Hits         6472     6472              
+ Misses        592      590       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see it supported as it can quite useful for some workflows.
Also nice to get ride of the skip linux conditions.😁

@RobPasMue
Copy link
Member Author

Nice to see it supported as it can quite useful for some workflows. Also nice to get ride of the skip linux conditions.😁

Step by step 😆 there are some tests still failing, but parity is the goal!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable repair tools in core services
4 participants