REFACTOR: Improve code quality and test coverage #5642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes include: - using pathlib instead of os; - avoid assert on non test method; - log instead of pass in try: except:; - general code refactoring.
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5642 +/- ##
==========================================
+ Coverage 84.00% 85.25% +1.25%
==========================================
Files 152 152
Lines 61008 61012 +4
==========================================
+ Hits 51247 52015 +768
+ Misses 9761 8997 -764 |
Samuelopez-ansys
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes to improve the code base:
- using
pathlibinstead ofos(we need to start somewhere);- avoid assert on core methods and only use it for test methods;
- log instead of pass in try: except:;
- general code refactoring.
Issue linked
Associated to #5504
Checklist