Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: HFSS Setup error #5618 #5619

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Devin-Crawford
Copy link
Contributor

Resolve #5618

Description

\ansys\aedt\core\modules\setup_templates.py

  • Change autosweep default from "LinearStep" to "LinearCount" to match the default behavior of HFSS.
  • Use "RangeCount": 501

\ansys\aedt\core\hfss.py

  • Update docstring errors for create_setup()

\ansys\aedt\core\application.py

  • Change default setup from 1 to 0 for HFSS where appropriate.

\ansys\aedt\core\application\analysis.py

  • Correct an error that would always use an auto-generated name for the setup.

Issue linked

Close #5618

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

\ansys\aedt\core\modules\setup_templates.py
- Change autosweep default from "LinearStep" to "LinearCount" to match the default behavior of HFSS.
- Use "RangeCount": 501

\ansys\aedt\core\hfss.py
- Update docstring errors for create_setup()

\ansys\aedt\core\application.py
- Change default setup from 1 to 0 for HFSS where appropriate.

\ansys\aedt\core\application\analysis.py
- Correct an error that would always use an auto-generated name for the setup.
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Dec 28, 2024
Copy link

codecov bot commented Dec 28, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 17.75%. Comparing base (3a67112) to head (c8a030b).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5619       +/-   ##
===========================================
- Coverage   85.26%   17.75%   -67.51%     
===========================================
  Files         152      152               
  Lines       61016    61017        +1     
===========================================
- Hits        52025    10835    -41190     
- Misses       8991    50182    +41191     

Copy link
Collaborator

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug located in Hfss.create_setup()
2 participants