Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: PyAEDT installer with wheelhouse #5599

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

SMoraisAnsys
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys commented Dec 20, 2024

Description

The current installer script file is not working with wheel house argument. This PR should fix it and also improve the code of the script.

Issue linked

Close #5591

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Dec 20, 2024
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.27%. Comparing base (fe63cde) to head (4a3d000).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5599      +/-   ##
==========================================
- Coverage   85.29%   85.27%   -0.03%     
==========================================
  Files         152      152              
  Lines       60907    60987      +80     
==========================================
+ Hits        51949    52004      +55     
- Misses       8958     8983      +25     

@Samuelopez-ansys Samuelopez-ansys merged commit 87ca0cc into main Dec 20, 2024
43 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the fix/pyaedt-installer-with-wheelhouse branch December 20, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install from wheelhouse is not working
2 participants