REFACTOR: Deprecate props and use properties #5584
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5584 +/- ##
===========================================
- Coverage 85.29% 43.36% -41.93%
===========================================
Files 152 152
Lines 60906 61001 +95
===========================================
- Hits 51948 26452 -25496
- Misses 8958 34549 +25591 |
Samuelopez-ansys
previously approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up of #5488 where a part of the changes broke an example, see ansys/pyaedt-examples#287
Note that the changes from
propstopropertiesmake total sense so I applied the same logic on other classes.Among changes, I also added documentation improvements.
Issue linked
ansys/pyaedt-examples#287