Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Icepak analysis class #5574

Merged
merged 9 commits into from
Dec 17, 2024
Merged

FEAT: Icepak analysis class #5574

merged 9 commits into from
Dec 17, 2024

Conversation

Samuelopez-ansys
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys commented Dec 16, 2024

Description

Add a new class to contain Icepak Analysis features.
Add type annotations in design.py

Issue linked

#5572

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 16, 2024
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 99.02913% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.29%. Comparing base (75afcb8) to head (338ab14).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5574      +/-   ##
==========================================
+ Coverage   85.27%   85.29%   +0.01%     
==========================================
  Files         151      152       +1     
  Lines       60840    60868      +28     
==========================================
+ Hits        51884    51915      +31     
+ Misses       8956     8953       -3     

@Samuelopez-ansys Samuelopez-ansys merged commit a68479b into main Dec 17, 2024
43 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the doc/issue_5572 branch December 17, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants